-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Media Item Menu - Identify Media Item #1369
Conversation
Swiftfin/Views/ItemEditorView/IdentifyItemView/IdentifyItemView.swift
Outdated
Show resolved
Hide resolved
…ndardize: CancellableLoadingButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for not responding earlier for some feedback. Instead of just commenting and waiting I've just updated with some of my changes, most notably by renaming and some redesign using other existing views.
Per the implementation of a unified cancel view like the video player, that view and flow is changed in my work in #1203. Something like that should be in DelayedProgressView
, but even then that view probably isn't the best here.
There are many changes that this flow should receive though:
- Change poster styling depending on media type. This will be more important when music is implemented.
ItemView
and all subsidiary views are way old, before I knew what I know now about about proper ways to update views in SwiftUI. They will need some refactoring to handle item updates, which is why I changed a bit inItemView.AboutView
to accommodate item updating but even that should be changed.- We need to figure out cache invalidation for the previous item images.
What's here is good for now!
This looks great! Thank you again for helping get this over the finish line. These changes all make sense and I'm very happy with the result! |
Summary
Creates an 'Identify' View to allow users to identify an item against Jellyfin Server's remote sources. This searches and matches for an item based on the Title, Original Title or Year. See the video for more detail!
Video
Fixing a mismatch where Jellyfin thought
Star Wars
wasPhineas & Ferb: Star Wars
. This video is correcting that match back to `Star Wars'.Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-29.at.03.08.31.mp4